Try to fix Windows CI (GitHub Actions -- vcpkg manifest mode) by stephengtuggy · Pull Request #518 · boostorg/python

stephengtuggy · 2026-06-04T00:17:35Z

Fixes #514 (hopefully)

stefanseefeld · 2026-06-14T17:18:51Z

thanks @stephengtuggy for the patch ! It's definitely a step in the right direction, but apparently not yet complete (the build fails).

…sed to the `faber` commands

stephengtuggy · 2026-06-17T19:08:20Z

thanks @stephengtuggy for the patch ! It's definitely a step in the right direction, but apparently not yet complete (the build fails).

@stefanseefeld you're welcome. I think I see what the problem is. I neglected to update the include directory passed to the faber commands. That should be fixed now.

stephengtuggy · 2026-06-17T22:27:48Z

Nope, still not right. And unfortunately, this may not be trivial to fix. I'm not sure if there is a singular Boost include directory that can be passed to faber. I think it may be more like a different include directory for each Boost component. How to handle this situation?

…ed for `vcpkgGitCommitId` prior to this PR

stephengtuggy · 2026-06-18T17:06:21Z

To eliminate a variable, I am going back to the same vcpkg baseline in the manifest file as was used for vcpkgGitCommitId prior to this PR. Let's see if that helps.

stefanseefeld · 2026-06-18T18:59:30Z

+        vcpkgDirectory: '${{ github.workspace }}/vcpkg'
+        runVcpkgInstall: true
+    - name: List directory contents
+      run: Get-ChildItem "${{ github.workspace }}/vcpkg" -Recurse -Force -File -Filter 'config.hpp'


Perhaps if you use -User . to start looking in the local directory instead of $github.workspace/vcpkg ?
Alternatively, I see that the install root can be set via the vcpkgArguments: '--x-manifest-root=${{ github.workspace }}/vcpkg' directive.

This command simply searches the <github workspace>/vcpkg directory and all subdirectories for a file named config.hpp. It is literally the equivalent of find "${{ github.workspace}}/vcpkg" -iname 'config.hpp' -type f. And it's not finding the file anywhere! I don't understand what is going on here. Why would this file not be present?

I'm not familiar with -User . in conjunction with the Get-ChildItem command. What would that do?

Yes, the install root can be set using the vcpkgArguments parameter, but I'm not sure it's best practice to do so.

stephengtuggy · 2026-06-18T21:21:18Z

It occurs to me that in my other projects that use vcpkg, I generally set the VCPKG_ROOT environment variable explicitly. This might be important. Trying it now.

…ects that use vcpkg

…bdirectories for config.hpp

… v3.0.0

stephengtuggy · 2026-06-20T17:56:26Z

Well, I can finally see where config.hpp is. It's in directory D:\a\python\python\969f6665-88a2-4c98-938e-ca9259871fec\vcpkg_installed\x64-windows\include\boost. In other words, '${{ github.workspace }}\<GUID>\vcpkg_installed\$VCPKG_DEFAULT_TRIPLET\include' would be the boost include directory setting for faber.

This raises some more questions: why? Where is this setting coming from? And does the GUID stay the same, or does it change every run?

…ectory

stefanseefeld · 2026-06-20T20:55:25Z

That's great progress ! But I agree, having to remember and hardcode such paths is cumbersome and fragile, so best to be avoided. So why not replace all that by a manually defined install root (specified vie vcpkgArguments) ?

stephengtuggy · 2026-06-20T21:27:36Z

That's great progress ! But I agree, having to remember and hardcode such paths is cumbersome and fragile, so best to be avoided. So why not replace all that by a manually defined install root (specified vie vcpkgArguments) ?

Yes, I guess that makes sense, actually. I was trying to set it using environment variables, but that doesn't seem to be working for some reason. Perhaps something closer to where vcpkg runs is overriding the relevant environment variable.

At any rate, the last run worked! So the GUID seems to stay the same with each run.

stephengtuggy · 2026-06-20T21:30:38Z

I don't think --x-manifest-root is the correct vcpkg argument for this purpose, by the way. I believe --x-manifest-root tells vcpkg where to find the manifest file (vcpkg.json), not where to install the packages it installs.

stephengtuggy · 2026-06-21T00:56:00Z

Looks like one can tell vcpkg where to install dependencies using the VCPKG_INSTALLED_DIR environment variable. I will try that.

…in `--with-boost-include=` faber parameters

…-boost-include=` faber parameters

stefanseefeld · 2026-06-21T13:51:18Z

+
    steps:
-    - uses: actions/checkout@v5
+    - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7


I see you are referring to all actions by sha. Is that really necessary ? Why not use a version tag instead ? Wouldn't that be simpler (more readable, easier to maintain, etc.) ?

Referring to GitHub Actions by SHA is considered a security best practice. See https://docs.github.com/en/actions/reference/security/secure-use?learn=getting_started#using-third-party-actions .

It's not too difficult to maintain if one uses a tool like Dependabot or Renovate[bot] to keep dependencies up to date, including GitHub Actions dependencies.

As for readability, I do at least include the version tag in a comment. Hopefully that helps at least a little bit.

Yes, I noticed. Thanks !
Please go ahead and merge this if you are satisfied with the PR. Many thanks again for all your effort on this ! I wouldn't have been able to pull this off on my own, as I haven't developed on & for Windows in a long time.
Your work will unblock a number of other changes that I was hesitant to add while the Windows build was broken, so I'm thrilled to see this being completed.
Cheers !

You're welcome! I am satisfied with the PR, but I don't see a Merge button. I probably don't have merge permissions at the moment.

Ah, makes sense. I suppose only team members have merge (or commit) permission. Let me merge this for now. If you want to contribute in the future, we can consider adding you to the team. Cheers !

Create vcpkg.json

f11618c

stephengtuggy changed the title ~~Create vcpkg.json~~ Try to fix Windows CI (GitHub Actions -- vcpkg manifest mode) Jun 4, 2026

Update test-windows.yml

8638eea

stephengtuggy marked this pull request as ready for review June 4, 2026 00:34

Update test-windows.yml: Fix the --with-boost-include directory pas…

c77ed5d

…sed to the `faber` commands

List vcpkg directory contents, looking for config.hpp

210231a

vcpkg.json: Go back to the same commit for builtin-baseline as was us…

bd14940

…ed for `vcpkgGitCommitId` prior to this PR

stefanseefeld reviewed Jun 18, 2026

View reviewed changes

stephengtuggy added 2 commits June 18, 2026 20:48

Merge branch 'boostorg:develop' into fix/windows-ci

5d00264

test-windows.yml: Set VCPKG_ROOT environment variable, etc.

b101bc8

stephengtuggy added 4 commits June 18, 2026 15:18

test-windows.yml: Make workflow much more like my other, working proj…

5f234ee

…ects that use vcpkg

test-windows.yml: Search the entire github.workspace directory and su…

7cf1dc4

…bdirectories for config.hpp

test-windows.yml: Update microsoft/setup-msbuild to latest version,…

bc83f51

… v3.0.0

vcpkg.json: Go back to latest vcpkg release for builtin-baseline

8ed3dbe

test-windows.yml: Try again to set the correct with-boost-include dir…

96a1891

…ectory

stephengtuggy added 2 commits June 20, 2026 17:59

test-windows.yml: Set VCPKG_INSTALLED_DIR env var, and use its value …

2732a51

…in `--with-boost-include=` faber parameters

test-windows.yml: Forgot to include /x64-windows/include in `--with…

2460f88

…-boost-include=` faber parameters

stefanseefeld reviewed Jun 21, 2026

View reviewed changes

stefanseefeld merged commit a017f08 into boostorg:develop Jun 21, 2026
15 checks passed

Conversation

stephengtuggy commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stefanseefeld commented Jun 14, 2026

Uh oh!

stephengtuggy commented Jun 17, 2026

Uh oh!

stephengtuggy commented Jun 17, 2026

Uh oh!

stephengtuggy commented Jun 18, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stephengtuggy Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stephengtuggy commented Jun 18, 2026

Uh oh!

stephengtuggy commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stefanseefeld commented Jun 20, 2026

Uh oh!

stephengtuggy commented Jun 20, 2026

Uh oh!

stephengtuggy commented Jun 20, 2026

Uh oh!

stephengtuggy commented Jun 21, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

stephengtuggy commented Jun 4, 2026 •

edited

Loading

stephengtuggy Jun 18, 2026 •

edited

Loading

stephengtuggy commented Jun 20, 2026 •

edited

Loading